[stubgen] align is_classmethod with is_staticmethod #18657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericmarkmartin
force-pushed
the
improve-inspection-is_classmethod
branch
from
7de3489 to
ea4bbf0
Compare
JukkaL
changed the title
ericmarkmartin
force-pushed
the
improve-inspection-is_classmethod
branch
5 times, most recently
from
7094d74 to
472917d
Compare
Make classmethod detection more in line with staticmethod detection. This correctly handles a few additional cases: for example, callables created via PyCMethod_New and friends will no longer be classified as classmethods.
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make classmethod detection more in line with staticmethod detection. While the current check of
inspect.isbuiltinworks most of the time, there are occasions where it doesn't work. For instance, callables created viaPyCMethod_Newand friends returnTrueunderinspect.isbuiltin.Also previously, I don't believe the check that the the object had type
classmethodorclassmethod_descriptorwas ever triggering, as the object was being looked up viagetattrand therefore with the descriptor protocol. Now, we use a raw lookup so we can actually get a hold of the descriptor.